Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52a08caa authored by Dave Ertman's avatar Dave Ertman Committed by Jeff Kirsher
Browse files

i40e: Fix static analysis tool warning 



This patch fixes a problem where a static analysis tool generates
a warning for "INVARIANT_CONDITION: Expression 'enabled_tc' used
in the condition always yields the same result."

Without this patch, the driver will not pass the static analysis
tool checks without generating warnings.

This patch fixes the problem by eliminating the irrelevant check
and redundant assignment for the value of enabled_tc.

Change-ID: Ia7d44cb050f507df7de333e96369d322e08bf408
Signed-off-by: default avatarDave Ertman <david.m.ertman@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 62fe2a86

drivers/net/ethernet/intel/i40e/i40e_main.c

+1 −3
Original line number Diff line number Diff line
@@ -4617,7 +4617,7 @@ static u8 i40e_dcb_get_enabled_tc(struct i40e_dcbx_config *dcbcfg) 
static u8 i40e_pf_get_num_tc(struct i40e_pf *pf)

{

	struct i40e_hw *hw = &pf->hw;

	u8 i, enabled_tc;

	u8 i, enabled_tc = 1;

	u8 num_tc = 0;

	struct i40e_dcbx_config *dcbcfg = &hw->local_dcbx_config;
@@ -4635,8 +4635,6 @@ static u8 i40e_pf_get_num_tc(struct i40e_pf *pf) 
	else

		return 1; /* Only TC0 */



	/* At least have TC0 */

	enabled_tc = (enabled_tc ? enabled_tc : 0x1);

	for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {

		if (enabled_tc & BIT(i))

			num_tc++;