Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5298c37f authored Apr 28, 2010 by Ben Hutchings Committed by David S. Miller Apr 28, 2010

sfc: Test only the first pair of TX queues



This makes no immediate difference, but we definitely do not want
to test all TX queues once we allocate a pair of TX queues to each
channel.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent affaf485

drivers/net/sfc/ethtool.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -304,7 +304,7 @@ static int efx_fill_loopback_test(struct efx_nic *efx,
		{
		struct efx_tx_queue *tx_queue;

		efx_for_each_tx_queue(tx_queue, efx) {
		efx_for_each_channel_tx_queue(tx_queue, &efx->channel[0]) {
		efx_fill_test(test_index++, strings, data,
		&lb_tests->tx_sent[tx_queue->queue],
		EFX_TX_QUEUE_NAME(tx_queue),

drivers/net/sfc/selftest.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -616,8 +616,8 @@ static int efx_test_loopbacks(struct efx_nic efx, struct efx_self_tests tests,
		goto out;
		}

		/* Test every TX queue */
		efx_for_each_tx_queue(tx_queue, efx) {
		/* Test both types of TX queue */
		efx_for_each_channel_tx_queue(tx_queue, &efx->channel[0]) {
		state->offload_csum = (tx_queue->queue ==
		EFX_TX_QUEUE_OFFLOAD_CSUM);
		rc = efx_test_loopback(tx_queue,