Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52933f05 authored by Kulikov Vasiliy's avatar Kulikov Vasiliy Committed by David S. Miller
Browse files

ibm_newemac: use free_netdev(netdev) instead of kfree() 

Freeing netdev without free_netdev() leads to net, tx leaks.
I might lead to dereferencing freed pointer.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

@@
struct net_device* dev;
@@

-kfree(dev)
+free_netdev(dev)

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 62038e4a

drivers/net/ibm_newemac/core.c

+2 −2
Original line number Diff line number Diff line
@@ -2928,7 +2928,7 @@ static int __devinit emac_probe(struct platform_device *ofdev, 
	if (dev->emac_irq != NO_IRQ)

		irq_dispose_mapping(dev->emac_irq);

 err_free:

	kfree(ndev);

	free_netdev(ndev);

 err_gone:

	/* if we were on the bootlist, remove us as we won't show up and

	 * wake up all waiters to notify them in case they were waiting
@@ -2971,7 +2971,7 @@ static int __devexit emac_remove(struct platform_device *ofdev) 
	if (dev->emac_irq != NO_IRQ)

		irq_dispose_mapping(dev->emac_irq);



	kfree(dev->ndev);

	free_netdev(dev->ndev);



	return 0;

}