Commit 525c411d authored Aug 26, 2008 by Nathan Fontenot Committed by Paul Mackerras Sep 15, 2008

powerpc: Check rc of notifier chain for memory remove



The return code from invocation of the notifier for
pSeries_reconfig_chain during update of the device tree is not
checked.  This causes writes to /proc/ppc64/ofdt to update memory
properties (i.e. ibm,dyamic-reconfiguration-memory) to always
return success, instead of the result of the notifier chain.

This happens specifically when we remove/add memory from the
device tree on machines using memory specified in the
ibm,dynamic-reconfiguration-memory property of the device tree.

Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>

parent 57dda6ef

arch/powerpc/platforms/pseries/reconfig.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -466,11 +466,11 @@ static int do_update_property(char *buf, size_t bufsize)
		else
		action = PSERIES_DRCONF_MEM_REMOVE;

		blocking_notifier_call_chain(&pSeries_reconfig_chain,
		rc = blocking_notifier_call_chain(&pSeries_reconfig_chain,
		action, value);
		}

		return 0;
		return rc;
		}

		/**