Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51eb1bb6 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

video: fbdev: clcdfb: Fix refcount leak in clcdfb_of_vram_setup 



[ Upstream commit b23789a59fa6f00e98a319291819f91fbba0deb8 ]

of_parse_phandle() returns a node pointer with refcount incremented, we should
use of_node_put() on it when not need anymore.  Add missing of_node_put() to
avoid refcount leak.

Fixes: d10715be ("video: ARM CLCD: Add DT support")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f7820f6d

drivers/video/fbdev/amba-clcd.c

+4 −1
Original line number Diff line number Diff line
@@ -838,12 +838,15 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb) 
		return -ENODEV;



	fb->fb.screen_base = of_iomap(memory, 0);

	if (!fb->fb.screen_base)

	if (!fb->fb.screen_base) {

		of_node_put(memory);

		return -ENOMEM;

	}



	fb->fb.fix.smem_start = of_translate_address(memory,

			of_get_address(memory, 0, &size, NULL));

	fb->fb.fix.smem_len = size;

	of_node_put(memory);



	return 0;

}