Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51a6256b authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Kukjin Kim
Browse files

ARM: EXYNOS: Fix double of_node_put() when parsing child power domains 



On each next iteration of for_each_compatible_node() the reference
counter for current device node is already decreased by the loop
iterator. The manual call to of_node_get() is required only on loop
break which is not happening here.

The double of_node_get() (with enabled CONFIG_OF_DYNAMIC) lead to
decreasing the counter below expected, initial value.

Fixes: fe4034a3 ("ARM: EXYNOS: Add missing of_node_put() when parsing power domains")
Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarKukjin Kim <kgene@kernel.org>
parent 6ff33f39

arch/arm/mach-exynos/pm_domains.c

+3 −5
Original line number Diff line number Diff line
@@ -200,15 +200,15 @@ static __init int exynos4_pm_init_power_domain(void) 
		args.args_count = 0;

		child_domain = of_genpd_get_from_provider(&args);

		if (IS_ERR(child_domain))

			goto next_pd;

			continue;



		if (of_parse_phandle_with_args(np, "power-domains",

					 "#power-domain-cells", 0, &args) != 0)

			goto next_pd;

			continue;



		parent_domain = of_genpd_get_from_provider(&args);

		if (IS_ERR(parent_domain))

			goto next_pd;

			continue;



		if (pm_genpd_add_subdomain(parent_domain, child_domain))

			pr_warn("%s failed to add subdomain: %s\n",
@@ -216,8 +216,6 @@ static __init int exynos4_pm_init_power_domain(void) 
		else

			pr_info("%s has as child subdomain: %s.\n",

				parent_domain->name, child_domain->name);

next_pd:

		of_node_put(np);

	}



	return 0;