Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51a246aa authored by Mark Brown's avatar Mark Brown
Browse files

regmap: Back out work buffer fix 



This reverts commit bc8ce4 (regmap: don't corrupt work buffer in
_regmap_raw_write()) since it turns out that it can cause issues when
taken in isolation from the other changes in -next that lead to its
discovery.  On the basis that nobody noticed the problems for quite some
time without that subsequent work let's drop it from v3.9.

Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 31880c37

drivers/base/regmap/regmap.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -943,7 +943,8 @@ static int _regmap_raw_write(struct regmap *map, unsigned int reg, 
		unsigned int ival;

		unsigned int ival;

		int val_bytes = map->format.val_bytes;

		int val_bytes = map->format.val_bytes;

		for (i = 0; i < val_len / val_bytes; i++) {

		for (i = 0; i < val_len / val_bytes; i++) {

			ival = map->format.parse_val(val + (i * val_bytes));

			memcpy(map->work_buf, val + (i * val_bytes), val_bytes);

			ival = map->format.parse_val(map->work_buf);

			ret = regcache_write(map, reg + (i * map->reg_stride),

			ret = regcache_write(map, reg + (i * map->reg_stride),

					     ival);

					     ival);

			if (ret) {

			if (ret) {