Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 518d8c3c authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

Bluetooth: increase BTNAMSIZ to 21 chars to fix potential buffer overflow



[ Upstream commit 713baf3dae8f45dc8ada4ed2f5fdcbf94a5c274d ]

An earlier commit replaced using batostr to using %pMR sprintf for the
construction of session->name. Static analysis detected that this new
method can use a total of 21 characters (including the trailing '\0')
so we need to increase the BTNAMSIZ from 18 to 21 to fix potential
buffer overflows.

Addresses-Coverity: ("Out-of-bounds write")
Fixes: fcb73338 ("Bluetooth: Use %pMR in sprintf/seq_printf instead of batostr")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 23beb85d
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@
#include <linux/types.h>
#include <net/bluetooth/bluetooth.h>

#define BTNAMSIZ 18
#define BTNAMSIZ 21

/* CMTP ioctl defines */
#define CMTPCONNADD	_IOW('C', 200, int)