Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 513f6750 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

USB: host: fhci: Re-use DEFINE_SHOW_ATTRIBUTE() macro 



...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 35a7e0a2

drivers/usb/host/fhci-dbg.c

+2 −24
Original line number Diff line number Diff line
@@ -55,6 +55,7 @@ static int fhci_dfs_regs_show(struct seq_file *s, void *v) 


	return 0;

}

DEFINE_SHOW_ATTRIBUTE(fhci_dfs_regs);



static int fhci_dfs_irq_stat_show(struct seq_file *s, void *v)

{
@@ -75,30 +76,7 @@ static int fhci_dfs_irq_stat_show(struct seq_file *s, void *v) 


	return 0;

}



static int fhci_dfs_regs_open(struct inode *inode, struct file *file)

{

	return single_open(file, fhci_dfs_regs_show, inode->i_private);

}



static int fhci_dfs_irq_stat_open(struct inode *inode, struct file *file)

{

	return single_open(file, fhci_dfs_irq_stat_show, inode->i_private);

}



static const struct file_operations fhci_dfs_regs_fops = {

	.open = fhci_dfs_regs_open,

	.read = seq_read,

	.llseek = seq_lseek,

	.release = single_release,

};



static const struct file_operations fhci_dfs_irq_stat_fops = {

	.open = fhci_dfs_irq_stat_open,

	.read = seq_read,

	.llseek = seq_lseek,

	.release = single_release,

};

DEFINE_SHOW_ATTRIBUTE(fhci_dfs_irq_stat);



void fhci_dfs_create(struct fhci_hcd *fhci)

{