Commit 5125e4e8 authored Sep 26, 2017 by Christophe Jaillet Committed by Herbert Xu Oct 07, 2017

crypto: xts - Fix an error handling path in 'create()'



All error handling paths 'goto err_drop_spawn' except this one.
In order to avoid some resources leak, we should do it as well here.

Fixes: f1c131b4 ("crypto: xts - Convert to skcipher")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 532f419c

crypto/xts.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -554,8 +554,10 @@ static int create(struct crypto_template tmpl, struct rtattr *tb)
		ctx->name[len - 1] = 0;

		if (snprintf(inst->alg.base.cra_name, CRYPTO_MAX_ALG_NAME,
		"xts(%s)", ctx->name) >= CRYPTO_MAX_ALG_NAME)
		return -ENAMETOOLONG;
		"xts(%s)", ctx->name) >= CRYPTO_MAX_ALG_NAME) {
		err = -ENAMETOOLONG;
		goto err_drop_spawn;
		}
		} else
		goto err_drop_spawn;