Commit 510dd460 authored Feb 06, 2017 by Jacob Keller Committed by Jeff Kirsher Mar 20, 2017

i40e: don't re-enable ATR when flushing filters if SB has TCP4/IPv4 rules



When flushing and replaying FDIR filters, it is possible we would
disable ATR, and then re-enable it even though we should have kept
it disabled due to existing TCP/IPv4 filters. Fix this by checking
whether we have TCP4/IPv4 filters before re-enabling.

Alternatively, we could instead restore ATR and then replay filters,
however, this would cause us to rapidly enable and then disable ATR in
some cases.

Change-ID: I076e4cc1e4409bce7f98f3c213295433a4ff43d8
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Avinash Dayanand <avinash.dayanand@intel.com>
Reviewed-by: Alan Brady <alan.brady@intel.com>
Reviewed-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 6d069425

drivers/net/ethernet/intel/i40e/i40e_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6228,7 +6228,7 @@ static void i40e_fdir_flush_and_replay(struct i40e_pf *pf)
		} else {
		/* replay sideband filters */
		i40e_fdir_filter_restore(pf->vsi[pf->lan_vsi]);
		if (!disable_atr)
		if (!disable_atr && !pf->fd_tcp_rule)
		pf->hw_disabled_flags &= ~I40E_FLAG_FD_ATR_ENABLED;
		clear_bit(__I40E_FD_FLUSH_REQUESTED, &pf->state);
		if (I40E_DEBUG_FD & pf->hw.debug_mask)