Commit 50b83d19 authored Aug 19, 2020 by Sumera Priyadarsini Committed by Greg Kroah-Hartman Sep 03, 2020

net: gianfar: Add of_node_put() before goto statement



[ Upstream commit 989e4da042ca4a56bbaca9223d1a93639ad11e17 ]

Every iteration of for_each_available_child_of_node() decrements
reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.

Fix a potential memory leak in gianfar.c by inserting of_node_put()
before the goto statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent b1215198

drivers/net/ethernet/freescale/gianfar.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -844,9 +844,11 @@ static int gfar_of_init(struct platform_device ofdev, struct net_device *pdev)
		continue;

		err = gfar_parse_group(child, priv, model);
		if (err)
		if (err) {
		of_node_put(child);
		goto err_grp_init;
		}
		}
		} else { /* SQ_SG_MODE */
		err = gfar_parse_group(np, priv, model);
		if (err)