Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 509c7d83 authored by Dave Airlie's avatar Dave Airlie
Browse files

drm/kms/fb: check for depth changes from userspace for resizing. 



If userspace (plymouth in this case) asks for a deeper depth,
refuse it as well due to lack of resizing.

This fixes an issue since < 32MB cards went to 8bpp and plymouth
crashes on startup.

Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 89347bb8

drivers/gpu/drm/drm_fb_helper.c

+4 −5
Original line number Diff line number Diff line
@@ -606,11 +606,10 @@ int drm_fb_helper_check_var(struct fb_var_screeninfo *var, 
		return -EINVAL;



	/* Need to resize the fb object !!! */

	if (var->xres > fb->width || var->yres > fb->height) {

		DRM_ERROR("Requested width/height is greater than current fb "

			   "object %dx%d > %dx%d\n", var->xres, var->yres,

			   fb->width, fb->height);

		DRM_ERROR("Need resizing code.\n");

	if (var->bits_per_pixel > fb->bits_per_pixel || var->xres > fb->width || var->yres > fb->height) {

		DRM_DEBUG("fb userspace requested width/height/bpp is greater than current fb "

			  "object %dx%d-%d > %dx%d-%d\n", var->xres, var->yres, var->bits_per_pixel,

			  fb->width, fb->height, fb->bits_per_pixel);

		return -EINVAL;

	}