Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50292710 authored by Varun Prakash's avatar Varun Prakash Committed by Martin K. Petersen
Browse files

scsi: libcxgbi: add check for valid cxgbi_task_data 



In error case it is possible that ->cleanup_task() gets called without
calling ->alloc_pdu() in this case cxgbi_task_data is not valid, so add
a check for for valid cxgbi_task_data in cxgbi_cleanup_task().

Signed-off-by: default avatarVarun Prakash <varun@chelsio.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 516b7db5

drivers/scsi/cxgbi/libcxgbi.c

+7 −0
Original line number Diff line number Diff line
@@ -2128,6 +2128,13 @@ void cxgbi_cleanup_task(struct iscsi_task *task) 
	struct iscsi_tcp_task *tcp_task = task->dd_data;

	struct cxgbi_task_data *tdata = iscsi_task_cxgbi_data(task);



	if (!tcp_task || !tdata || (tcp_task->dd_data != tdata)) {

		pr_info("task 0x%p,0x%p, tcp_task 0x%p, tdata 0x%p/0x%p.\n",

			task, task->sc, tcp_task,

			tcp_task ? tcp_task->dd_data : NULL, tdata);

		return;

	}



	log_debug(1 << CXGBI_DBG_ISCSI,

		"task 0x%p, skb 0x%p, itt 0x%x.\n",

		task, tdata->skb, task->hdr_itt);