Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50220dea authored by Benjamin Tissoires's avatar Benjamin Tissoires Committed by Jiri Kosina
Browse files

HID: core: prevent out-of-bound readings 



Plugging a Logitech DJ receiver with KASAN activated raises a bunch of
out-of-bound readings.

The fields are allocated up to MAX_USAGE, meaning that potentially, we do
not have enough fields to fit the incoming values.
Add checks and silence KASAN.

Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 5137b354

drivers/hid/hid-core.c

+3 −0
Original line number Diff line number Diff line
@@ -1293,6 +1293,7 @@ static void hid_input_field(struct hid_device *hid, struct hid_field *field, 
		/* Ignore report if ErrorRollOver */

		if (!(field->flags & HID_MAIN_ITEM_VARIABLE) &&

		    value[n] >= min && value[n] <= max &&

		    value[n] - min < field->maxusage &&

		    field->usage[value[n] - min].hid == HID_UP_KEYBOARD + 1)

			goto exit;

	}
@@ -1305,11 +1306,13 @@ static void hid_input_field(struct hid_device *hid, struct hid_field *field, 
		}



		if (field->value[n] >= min && field->value[n] <= max

			&& field->value[n] - min < field->maxusage

			&& field->usage[field->value[n] - min].hid

			&& search(value, field->value[n], count))

				hid_process_event(hid, field, &field->usage[field->value[n] - min], 0, interrupt);



		if (value[n] >= min && value[n] <= max

			&& value[n] - min < field->maxusage

			&& field->usage[value[n] - min].hid

			&& search(field->value, value[n], count))

				hid_process_event(hid, field, &field->usage[value[n] - min], 1, interrupt);