Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50054a92 authored by Jozsef Kadlecsik's avatar Jozsef Kadlecsik
Browse files

Fix bug: sometimes valid entries in hash:* types of sets were evicted 



Wrong index was used and therefore when shrinking a hash bucket at
deleting an entry, valid entries could be evicted as well.
Thanks to Eric Ewanco for the thorough bugreport.

Fixes netfilter bugzilla #1119

Signed-off-by: default avatarJozsef Kadlecsik <kadlec@blackhole.kfki.hu>
parent f95d7a46

net/netfilter/ipset/ip_set_hash_gen.h

+1 −1
Original line number Diff line number Diff line
@@ -897,7 +897,7 @@ mtype_del(struct ip_set *set, void *value, const struct ip_set_ext *ext, 
					continue;

				data = ahash_data(n, j, dsize);

				memcpy(tmp->value + k * dsize, data, dsize);

				set_bit(j, tmp->used);

				set_bit(k, tmp->used);

				k++;

			}

			tmp->pos = k;