Commit 4ffc945b authored Sep 17, 2020 by James Smart Committed by Greg Kroah-Hartman Oct 07, 2020

nvme-fc: fail new connections to a deleted host or remote port



[ Upstream commit 9e0e8dac985d4bd07d9e62922b9d189d3ca2fccf ]

The lldd may have made calls to delete a remote port or local port and
the delete is in progress when the cli then attempts to create a new
controller. Currently, this proceeds without error although it can't be
very successful.

Fix this by validating that both the host port and remote port are
present when a new controller is to be created.

Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 8f72de67

drivers/nvme/host/fc.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -3294,12 +3294,14 @@ nvme_fc_create_ctrl(struct device dev, struct nvmf_ctrl_options opts)
		spin_lock_irqsave(&nvme_fc_lock, flags);
		list_for_each_entry(lport, &nvme_fc_lport_list, port_list) {
		if (lport->localport.node_name != laddr.nn \|\|
		lport->localport.port_name != laddr.pn)
		lport->localport.port_name != laddr.pn \|\|
		lport->localport.port_state != FC_OBJSTATE_ONLINE)
		continue;

		list_for_each_entry(rport, &lport->endp_list, endp_list) {
		if (rport->remoteport.node_name != raddr.nn \|\|
		rport->remoteport.port_name != raddr.pn)
		rport->remoteport.port_name != raddr.pn \|\|
		rport->remoteport.port_state != FC_OBJSTATE_ONLINE)
		continue;

		/* if fail to get reference fall through. Will error */