Commit 4fd1bd44 authored Jul 21, 2017 by Laurent Vivier Committed by Michael Ellerman Jul 26, 2017

powerpc/pseries: Fix of_node_put() underflow during reconfig remove



As for commit 68baf692 ("powerpc/pseries: Fix of_node_put()
underflow during DLPAR remove"), the call to of_node_put() must be
removed from pSeries_reconfig_remove_node().

dlpar_detach_node() and pSeries_reconfig_remove_node() both call
of_detach_node(), and thus the node should not be released in both
cases.

Fixes: 0829f6d1 ("of: device_node kobject lifecycle fixes")
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent a25bd72b

arch/powerpc/platforms/pseries/reconfig.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -82,7 +82,6 @@ static int pSeries_reconfig_remove_node(struct device_node *np)

		of_detach_node(np);
		of_node_put(parent);
		of_node_put(np); /* Must decrement the refcount */
		return 0;
		}