Commit 4f9adc8f authored Aug 08, 2017 by Todd Kjos Committed by Greg Kroah-Hartman Aug 22, 2017

binder: fix incorrect cmd to binder_stat_br



commit 26549d17 ("binder: guarantee txn complete / errors delivered
in-order") passed the locally declared and undefined cmd
to binder_stat_br() which results in a bogus cmd field in a trace
event and BR stats are incremented incorrectly.

Change to use e->cmd which has been initialized.

Signed-off-by: Todd Kjos <tkjos@google.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 26549d17 ("binder: guarantee txn complete / errors delivered in-order")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 22eb9476

drivers/android/binder.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3619,7 +3619,7 @@ static int binder_thread_read(struct binder_proc *proc,
		e->cmd = BR_OK;
		ptr += sizeof(uint32_t);

		binder_stat_br(proc, thread, cmd);
		binder_stat_br(proc, thread, e->cmd);
		} break;
		case BINDER_WORK_TRANSACTION_COMPLETE: {
		binder_inner_proc_unlock(proc);