Commit 4f678a58 authored May 14, 2006 by Jesper Juhl Committed by David Woodhouse May 14, 2006

mtd: fix memory leaks in phram_setup



There are two code paths in drivers/mtd/devices/phram.c::phram_setup() that
will leak memory.
Memory is allocated to the variable 'name' with kmalloc() by the
parse_name() function, but if we leave by way of the parse_err() macro,
then that memory is never kfree()'d, nor is it ever used with
register_device() so it won't be freed later either - leak.

Found by the Coverity checker as #593 - simple fix below.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>

parent e0c7d767

drivers/mtd/devices/phram.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -266,12 +266,16 @@ static int phram_setup(const char val, struct kernel_param kp)
		return 0;

		ret = parse_num32(&start, token[1]);
		if (ret)
		if (ret) {
		kfree(name);
		parse_err("illegal start address\n");
		}

		ret = parse_num32(&len, token[2]);
		if (ret)
		if (ret) {
		kfree(name);
		parse_err("illegal device length\n");
		}

		register_device(name, start, len);