Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f5877bd authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

soc: bcm: brcmstb: pm: pm-arm: Fix refcount leak in brcmstb_pm_probe 



commit 37d838de369b07b596c19ff3662bf0293fdb09ee upstream.

of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

In brcmstb_init_sram, it pass dn to of_address_to_resource(),
of_address_to_resource() will call of_find_device_by_node() to take
reference, so we should release the reference returned by
of_find_matching_node().

Fixes: 0b741b82 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7571bcec

drivers/soc/bcm/brcmstb/pm/pm-arm.c

+1 −0
Original line number Diff line number Diff line
@@ -788,6 +788,7 @@ static int brcmstb_pm_probe(struct platform_device *pdev) 
	}



	ret = brcmstb_init_sram(dn);

	of_node_put(dn);

	if (ret) {

		pr_err("error setting up SRAM for PM\n");

		return ret;