Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f32e9b1 authored by Yong Zhang's avatar Yong Zhang Committed by Tejun Heo
Browse files

kthread_work: make lockdep happy 



spinlock in kthread_worker and wait_queue_head in kthread_work both
should be lockdep sensible, so change the interface to make it
suiltable for CONFIG_LOCKDEP.

tj: comment update

Reported-by: default avatarNicolas <nicolas.mailhot@laposte.net>
Signed-off-by: default avatarYong Zhang <yong.zhang0@gmail.com>
Signed-off-by: default avatarAndy Walls <awalls@md.metrocast.net>
Tested-by: default avatarAndy Walls <awalls@md.metrocast.net>
Cc: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 90a8a73c

include/linux/kthread.h

+35 −10
Original line number Diff line number Diff line
@@ -81,16 +81,41 @@ struct kthread_work { 
#define DEFINE_KTHREAD_WORK(work, fn)					\

	struct kthread_work work = KTHREAD_WORK_INIT(work, fn)



static inline void init_kthread_worker(struct kthread_worker *worker)

{

	*worker = (struct kthread_worker)KTHREAD_WORKER_INIT(*worker);

}



static inline void init_kthread_work(struct kthread_work *work,

				     kthread_work_func_t fn)

{

	*work = (struct kthread_work)KTHREAD_WORK_INIT(*work, fn);

}

/*

 * kthread_worker.lock and kthread_work.done need their own lockdep class

 * keys if they are defined on stack with lockdep enabled.  Use the

 * following macros when defining them on stack.

 */

#ifdef CONFIG_LOCKDEP

# define KTHREAD_WORKER_INIT_ONSTACK(worker)				\

	({ init_kthread_worker(&worker); worker; })

# define DEFINE_KTHREAD_WORKER_ONSTACK(worker)				\

	struct kthread_worker worker = KTHREAD_WORKER_INIT_ONSTACK(worker)

# define KTHREAD_WORK_INIT_ONSTACK(work, fn)				\

	({ init_kthread_work((&work), fn); work; })

# define DEFINE_KTHREAD_WORK_ONSTACK(work, fn)				\

	struct kthread_work work = KTHREAD_WORK_INIT_ONSTACK(work, fn)

#else

# define DEFINE_KTHREAD_WORKER_ONSTACK(worker) DEFINE_KTHREAD_WORKER(worker)

# define DEFINE_KTHREAD_WORK_ONSTACK(work, fn) DEFINE_KTHREAD_WORK(work, fn)

#endif



extern void __init_kthread_worker(struct kthread_worker *worker,

			const char *name, struct lock_class_key *key);



#define init_kthread_worker(worker)					\

	do {								\

		static struct lock_class_key __key;			\

		__init_kthread_worker((worker), "("#worker")->lock", &__key); \

	} while (0)



#define init_kthread_work(work, fn)					\

	do {								\

		memset((work), 0, sizeof(struct kthread_work));		\

		INIT_LIST_HEAD(&(work)->node);				\

		(work)->func = (fn);					\

		init_waitqueue_head(&(work)->done);			\

	} while (0)



int kthread_worker_fn(void *worker_ptr);

kernel/kthread.c

+11 −0
Original line number Diff line number Diff line
@@ -265,6 +265,17 @@ int kthreadd(void *unused) 
	return 0;

}



void __init_kthread_worker(struct kthread_worker *worker,

				const char *name,

				struct lock_class_key *key)

{

	spin_lock_init(&worker->lock);

	lockdep_set_class_and_name(&worker->lock, key, name);

	INIT_LIST_HEAD(&worker->work_list);

	worker->task = NULL;

}

EXPORT_SYMBOL_GPL(__init_kthread_worker);



/**

 * kthread_worker_fn - kthread function to process kthread_worker

 * @worker_ptr: pointer to initialized kthread_worker