Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f256d56 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Michael Ellerman
Browse files

macintosh: change some data types from int to bool 



Change the data type of the following variables from int to bool
across all macintosh drivers:

started
slots_started
pm121_started
wf_smu_started

Some of these issues were detected with the help of Coccinelle.

Suggested-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 0bc00914

drivers/macintosh/therm_adt746x.c

+2 −2
Original line number Diff line number Diff line
@@ -230,7 +230,7 @@ static void update_fans_speed (struct thermostat *th) 


	/* we don't care about local sensor, so we start at sensor 1 */

	for (i = 1; i < 3; i++) {

		int started = 0;

		bool started = false;

		int fan_number = (th->type == ADT7460 && i == 2);

		int var = th->temps[i] - th->limits[i];
@@ -243,7 +243,7 @@ static void update_fans_speed (struct thermostat *th) 
			if (abs(var - th->last_var[fan_number]) < 2)

				continue;



			started = 1;

			started = true;

			new_speed = fan_speed + ((var-1)*step);



			if (new_speed < fan_speed)

drivers/macintosh/windfarm_pm112.c

+4 −4
Original line number Diff line number Diff line
@@ -96,14 +96,14 @@ static int cpu_last_target; 
static struct wf_pid_state backside_pid;

static int backside_tick;

static struct wf_pid_state slots_pid;

static int slots_started;

static bool slots_started;

static struct wf_pid_state drive_bay_pid;

static int drive_bay_tick;



static int nr_cores;

static int have_all_controls;

static int have_all_sensors;

static int started;

static bool started;



static int failure_state;

#define FAILURE_SENSOR		1
@@ -462,7 +462,7 @@ static void slots_fan_tick(void) 
		/* first time; initialize things */

		printk(KERN_INFO "windfarm: Slots control loop started.\n");

		wf_pid_init(&slots_pid, &slots_param);

		slots_started = 1;

		slots_started = true;

	}



	err = slots_power->ops->get_value(slots_power, &power);
@@ -506,7 +506,7 @@ static void pm112_tick(void) 
	int i, last_failure;



	if (!started) {

		started = 1;

		started = true;

		printk(KERN_INFO "windfarm: CPUs control loops started.\n");

		for (i = 0; i < nr_cores; ++i) {

			if (create_cpu_loop(i) < 0) {

drivers/macintosh/windfarm_pm121.c

+3 −2
Original line number Diff line number Diff line
@@ -246,7 +246,8 @@ enum { 
static struct wf_control *controls[N_CONTROLS] = {};



/* Set to kick the control loop into life */

static int pm121_all_controls_ok, pm121_all_sensors_ok, pm121_started;

static int pm121_all_controls_ok, pm121_all_sensors_ok;

static bool pm121_started;



enum {

	FAILURE_FAN		= 1 << 0,
@@ -806,7 +807,7 @@ static void pm121_tick(void) 
			pm121_create_sys_fans(i);



		pm121_create_cpu_fans();

		pm121_started = 1;

		pm121_started = true;

	}



	/* skipping ticks */

drivers/macintosh/windfarm_pm72.c

+1 −1
Original line number Diff line number Diff line
@@ -611,7 +611,7 @@ static void pm72_tick(void) 
	int i, last_failure;



	if (!started) {

		started = 1;

		started = true;

		printk(KERN_INFO "windfarm: CPUs control loops started.\n");

		for (i = 0; i < nr_chips; ++i) {

			if (cpu_setup_pid(i) < 0) {

drivers/macintosh/windfarm_pm81.c

+3 −2
Original line number Diff line number Diff line
@@ -140,7 +140,8 @@ static struct wf_control *fan_system; 
static struct wf_control *cpufreq_clamp;



/* Set to kick the control loop into life */

static int wf_smu_all_controls_ok, wf_smu_all_sensors_ok, wf_smu_started;

static int wf_smu_all_controls_ok, wf_smu_all_sensors_ok;

static bool wf_smu_started;



/* Failure handling.. could be nicer */

#define FAILURE_FAN		0x01
@@ -549,7 +550,7 @@ static void wf_smu_tick(void) 
		DBG("wf: creating control loops !\n");

		wf_smu_create_sys_fans();

		wf_smu_create_cpu_fans();

		wf_smu_started = 1;

		wf_smu_started = true;

	}



	/* Skipping ticks */