Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f060736 authored by Quinn Tran's avatar Quinn Tran Committed by Bart Van Assche
Browse files

qla2xxx: Fix erroneous invalid handle message 



Termination of Immediate Notify IOCB was using wrong
IOCB handle. IOCB completion code was unable to find
appropriate code path due to wrong handle.

Following message is seen in the logs.

"Error entry - invalid handle/queue (ffff)."

Signed-off-by: default avatarQuinn Tran <quinn.tran@cavium.com>
Signed-off-by: default avatarHimanshu Madhani <himanshu.madhani@cavium.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
[ bvanassche: Fixed word order in patch title ]
Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
parent 200ffb15

drivers/scsi/qla2xxx/qla_isr.c

+4 −0
Original line number Diff line number Diff line
@@ -2496,6 +2496,10 @@ qla2x00_error_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, sts_entry_t *pkt) 
	if (pkt->entry_status & RF_BUSY)

		res = DID_BUS_BUSY << 16;



	if (pkt->entry_type == NOTIFY_ACK_TYPE &&

	    pkt->handle == QLA_TGT_SKIP_HANDLE)

		return;



	sp = qla2x00_get_sp_from_handle(vha, func, req, pkt);

	if (sp) {

		sp->done(ha, sp, res);

drivers/scsi/qla2xxx/qla_target.c

+1 −1
Original line number Diff line number Diff line
@@ -3061,7 +3061,7 @@ static int __qlt_send_term_imm_notif(struct scsi_qla_host *vha, 


	pkt->entry_type = NOTIFY_ACK_TYPE;

	pkt->entry_count = 1;

	pkt->handle = QLA_TGT_SKIP_HANDLE | CTIO_COMPLETION_HANDLE_MARK;

	pkt->handle = QLA_TGT_SKIP_HANDLE;



	nack = (struct nack_to_isp *)pkt;

	nack->ox_id = ntfy->ox_id;