Commit 4e4636cf authored Feb 27, 2017 by Josh Poimboeuf Committed by Ingo Molnar Feb 28, 2017

objtool: Enclose contents of unreachable() macro in a block



Guenter Roeck reported a boot failure in mips64.  It was bisected to the
following commit:

  d1091c7f ("objtool: Improve detection of BUG() and other dead ends")

The unreachable() macro was formerly only composed of a single
statement.  The above commit added a second statement, but neglected to
enclose the statements in a block.

Suggested-by: Guenter Roeck <linux@roeck-us.net>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: d1091c7f ("objtool: Improve detection of BUG() and other dead ends")
Link: http://lkml.kernel.org/r/20170228042116.glmwmwiohcix7o4a@treble


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 3d1e2360

include/linux/compiler-gcc.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -215,7 +215,8 @@
		* this in the preprocessor, but we can live with this because they're
		* unreleased. Really, we need to have autoconf for the kernel.
		*/
		#define unreachable() annotate_unreachable(); __builtin_unreachable()
		#define unreachable() \
		do { annotate_unreachable(); __builtin_unreachable(); } while (0)

		/* Mark a function definition as prohibited from being cloned. */
		#define __noclone __attribute__((__noclone__, __optimize__("no-tracer")))