Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e3b9baa authored by Markus Elfring's avatar Markus Elfring Committed by Sebastian Reichel
Browse files

HSI: nokia-modem: Delete error messages for a failed memory allocation in two functions 

The script "checkpatch.pl" pointed information out like the following.

WARNING: Possible unnecessary 'out of memory' message

Thus remove such statements here.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf


Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
parent 1be0593f

drivers/hsi/clients/nokia-modem.c

+3 −6
Original line number Diff line number Diff line
@@ -104,10 +104,8 @@ static int nokia_modem_gpio_probe(struct device *dev) 


	modem->gpios = devm_kcalloc(dev, gpio_count, sizeof(*modem->gpios),

				    GFP_KERNEL);

	if (!modem->gpios) {

		dev_err(dev, "Could not allocate memory for gpios\n");

	if (!modem->gpios)

		return -ENOMEM;

	}



	modem->gpio_amount = gpio_count;
@@ -156,10 +154,9 @@ static int nokia_modem_probe(struct device *dev) 
	}



	modem = devm_kzalloc(dev, sizeof(*modem), GFP_KERNEL);

	if (!modem) {

		dev_err(dev, "Could not allocate memory for nokia_modem_device\n");

	if (!modem)

		return -ENOMEM;

	}



	dev_set_drvdata(dev, modem);

	modem->device = dev;