Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4dffbe03 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Fix HP and Front pins of ad1988/ad1989 in ad198x_power_eapd() 



In ad198x_power_eapd(), wrong pin NIDs are used for controlling EAPD for
HP and Front outputs of AD1988/AD1989.  These are actually same with the
ones for AD1984 & co, port-A is 0x11 and port-D 0x12.

Reported-by: default avatarRaymond Yau <superquad.vortex2@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent bf0be0e9

sound/pci/hda/patch_analog.c

+4 −6
Original line number Original line Diff line number Diff line
@@ -524,6 +524,10 @@ static void ad198x_power_eapd(struct hda_codec *codec) 
	case 0x11d4184a:

	case 0x11d4184a:

	case 0x11d4194a:

	case 0x11d4194a:

	case 0x11d4194b:

	case 0x11d4194b:

	case 0x11d41988:

	case 0x11d4198b:

	case 0x11d4989a:

	case 0x11d4989b:

		ad198x_power_eapd_write(codec, 0x12, 0x11);

		ad198x_power_eapd_write(codec, 0x12, 0x11);

		break;

		break;

	case 0x11d41981:

	case 0x11d41981:
@@ -533,12 +537,6 @@ static void ad198x_power_eapd(struct hda_codec *codec) 
	case 0x11d41986:

	case 0x11d41986:

		ad198x_power_eapd_write(codec, 0x1b, 0x1a);

		ad198x_power_eapd_write(codec, 0x1b, 0x1a);

		break;

		break;

	case 0x11d41988:

	case 0x11d4198b:

	case 0x11d4989a:

	case 0x11d4989b:

		ad198x_power_eapd_write(codec, 0x29, 0x22);

		break;

	}

	}

}

}