Commit 4dfdc464 authored Dec 30, 2008 by Jiri Kosina

HID: fix error condition propagation in hid-sony driver



sony_set_operational() only propagates return value from
usb_control_msg(), which returns negative on error and number
of transferred bytes otherwise.

Reported-by: Marcin Tolysz <tolysz@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent b8a832b1

drivers/hid/hid-sony.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -102,7 +102,7 @@ static int sony_probe(struct hid_device hdev, const struct hid_device_id id)
		}

		ret = sony_set_operational(hdev);
		if (ret)
		if (ret < 0)
		goto err_stop;

		return 0;