Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4de2d58b authored by Maxime Ripard's avatar Maxime Ripard
Browse files

clk: sunxi: tcon-ch1: Do not return a negative error in get_parent 



get_parent is supposed to return an unsigned 8 bit integer, so returning
-EINVAL is a bad idea.

Remove it.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
parent 1a695a90

drivers/clk/sunxi/clk-sun4i-tcon-ch1.c

+0 −3
Original line number Diff line number Diff line
@@ -85,9 +85,6 @@ static u8 tcon_ch1_get_parent(struct clk_hw *hw) 
	reg = readl(tclk->reg) >> TCON_CH1_SCLK2_MUX_SHIFT;

	reg &= reg >> TCON_CH1_SCLK2_MUX_MASK;



	if (reg >= num_parents)

		return -EINVAL;



	return reg;

}