Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4dde99bd authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Mark Brown
Browse files

spi/bcm63xx: Move default clock configuration to kill compiler warning 



drivers/spi/spi-bcm63xx.c: In function ‘bcm63xx_spi_setup_transfer’:
drivers/spi/spi-bcm63xx.c:207: warning: ‘clk_cfg’ may be used uninitialized in this function

While this is a false positive, it can easily be avoided by selecting
the default clock configuration first.

Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8005c49d

drivers/spi/spi-bcm63xx.c

+3 −4
Original line number Diff line number Diff line
@@ -207,6 +207,9 @@ static void bcm63xx_spi_setup_transfer(struct spi_device *spi, 
	u8 clk_cfg, reg;

	int i;



	/* Default to lowest clock configuration */

	clk_cfg = SPI_CLK_0_391MHZ;



	/* Find the closest clock configuration */

	for (i = 0; i < SPI_CLK_MASK; i++) {

		if (t->speed_hz >= bcm63xx_spi_freq_table[i][0]) {
@@ -215,10 +218,6 @@ static void bcm63xx_spi_setup_transfer(struct spi_device *spi, 
		}

	}



	/* No matching configuration found, default to lowest */

	if (i == SPI_CLK_MASK)

		clk_cfg = SPI_CLK_0_391MHZ;



	/* clear existing clock configuration bits of the register */

	reg = bcm_spi_readb(bs, SPI_CLK_CFG);

	reg &= ~SPI_CLK_MASK;