Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4dbc8ef7 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo Committed by David S. Miller
Browse files

net: Make inet_twsk_put similar to sock_put 



By separating the freeing code from the refcounting decrementing.
Probably reducing icache pressure when we still have reference counts to
go.

Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9ce77666

net/ipv4/inet_timewait_sock.c

+13 −10
Original line number Original line Diff line number Diff line
@@ -49,19 +49,22 @@ static void __inet_twsk_kill(struct inet_timewait_sock *tw, 
	inet_twsk_put(tw);

	inet_twsk_put(tw);

}

}





void inet_twsk_put(struct inet_timewait_sock *tw)

static noinline void inet_twsk_free(struct inet_timewait_sock *tw)

{

{

	if (atomic_dec_and_test(&tw->tw_refcnt)) {

	struct module *owner = tw->tw_prot->owner;

	struct module *owner = tw->tw_prot->owner;

	twsk_destructor((struct sock *)tw);

	twsk_destructor((struct sock *)tw);

#ifdef SOCK_REFCNT_DEBUG

#ifdef SOCK_REFCNT_DEBUG

		printk(KERN_DEBUG "%s timewait_sock %p released\n",

	pr_debug("%s timewait_sock %p released\n", tw->tw_prot->name, tw);

		       tw->tw_prot->name, tw);

#endif

#endif

	release_net(twsk_net(tw));

	release_net(twsk_net(tw));

	kmem_cache_free(tw->tw_prot->twsk_prot->twsk_slab, tw);

	kmem_cache_free(tw->tw_prot->twsk_prot->twsk_slab, tw);

	module_put(owner);

	module_put(owner);

}

}



void inet_twsk_put(struct inet_timewait_sock *tw)

{

	if (atomic_dec_and_test(&tw->tw_refcnt))

		inet_twsk_free(tw);

}

}

EXPORT_SYMBOL_GPL(inet_twsk_put);

EXPORT_SYMBOL_GPL(inet_twsk_put);