Commit 4d4d8573 authored Nov 29, 2015 by Al Viro Committed by Jens Axboe Dec 30, 2015

bcache: fix a leak in bch_cached_dev_run()



Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Tested-by: Joshua Schmid <jschmid@suse.com>
Tested-by: Eric Wheeler <bcache@linux.ewheeler.net>
Cc: Kent Overstreet <kmo@daterainc.com>
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@fb.com>

parent fecaee6f

drivers/md/bcache/super.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -849,8 +849,11 @@ void bch_cached_dev_run(struct cached_dev *dc)
		buf[SB_LABEL_SIZE] = '\0';
		env[2] = kasprintf(GFP_KERNEL, "CACHED_LABEL=%s", buf);

		if (atomic_xchg(&dc->running, 1))
		if (atomic_xchg(&dc->running, 1)) {
		kfree(env[1]);
		kfree(env[2]);
		return;
		}

		if (!d->c &&
		BDEV_STATE(&dc->sb) != BDEV_STATE_NONE) {