Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d3ac666 authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by Stephen Boyd
Browse files

clk: bcm2835: fix check of error code returned by devm_ioremap_resource() 



The change fixes potential oops while accessing iomem on invalid
address, if devm_ioremap_resource() fails due to some reason.

The devm_ioremap_resource() function returns ERR_PTR() and never
returns NULL, which makes useless a following check for NULL.

Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Fixes: 5e63dcc7 ("clk: bcm2835: Add a driver for the auxiliary peripheral clock gates")
Reviewed-by: default avatarEric Anholt <eric@anholt.net>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent e8087b5b

drivers/clk/bcm/clk-bcm2835-aux.c

+2 −2
Original line number Diff line number Diff line
@@ -38,8 +38,8 @@ static int bcm2835_aux_clk_probe(struct platform_device *pdev) 


	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	reg = devm_ioremap_resource(dev, res);

	if (!reg)

		return -ENODEV;

	if (IS_ERR(reg))

		return PTR_ERR(reg);



	onecell = devm_kmalloc(dev, sizeof(*onecell), GFP_KERNEL);

	if (!onecell)