Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d2acd9e authored by Len Brown's avatar Len Brown
Browse files

Revert "ACPICA: revert "acpi_serialize" changes" 



This reverts commit a8f4af6d.
Thus restoring ACPICA's new acpi_serialize code.

This commit by itself may cause a regression, but
it is reverted in this order so that subsequent
reverts reverts under this one can be made
without conflict.

Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent b5f0adbc

drivers/acpi/events/evmisc.c

+2 −6
Original line number Diff line number Diff line
@@ -196,15 +196,11 @@ acpi_ev_queue_notify_request(struct acpi_namespace_node * node, 
		notify_info->notify.value = (u16) notify_value;

		notify_info->notify.handler_obj = handler_obj;



		acpi_ex_exit_interpreter();

		acpi_ex_relinquish_interpreter();



		acpi_ev_notify_dispatch(notify_info);



		status = acpi_ex_enter_interpreter();

		if (ACPI_FAILURE(status)) {

			return_ACPI_STATUS(status);

		}



		acpi_ex_reacquire_interpreter();

	}



	if (!handler_obj) {

drivers/acpi/events/evregion.c

+4 −11
Original line number Diff line number Diff line
@@ -291,7 +291,6 @@ acpi_ev_address_space_dispatch(union acpi_operand_object *region_obj, 
			       u32 bit_width, acpi_integer * value)

{

	acpi_status status;

	acpi_status status2;

	acpi_adr_space_handler handler;

	acpi_adr_space_setup region_setup;

	union acpi_operand_object *handler_desc;
@@ -345,7 +344,7 @@ acpi_ev_address_space_dispatch(union acpi_operand_object *region_obj, 
		 * setup will potentially execute control methods

		 * (e.g., _REG method for this region)

		 */

		acpi_ex_exit_interpreter();

		acpi_ex_relinquish_interpreter();



		status = region_setup(region_obj, ACPI_REGION_ACTIVATE,

				      handler_desc->address_space.context,
@@ -353,10 +352,7 @@ acpi_ev_address_space_dispatch(union acpi_operand_object *region_obj, 


		/* Re-enter the interpreter */



		status2 = acpi_ex_enter_interpreter();

		if (ACPI_FAILURE(status2)) {

			return_ACPI_STATUS(status2);

		}

		acpi_ex_reacquire_interpreter();



		/* Check for failure of the Region Setup */
@@ -409,7 +405,7 @@ acpi_ev_address_space_dispatch(union acpi_operand_object *region_obj, 
		 * exit the interpreter because the handler *might* block -- we don't

		 * know what it will do, so we can't hold the lock on the intepreter.

		 */

		acpi_ex_exit_interpreter();

		acpi_ex_relinquish_interpreter();

	}



	/* Call the handler */
@@ -430,10 +426,7 @@ acpi_ev_address_space_dispatch(union acpi_operand_object *region_obj, 
		 * We just returned from a non-default handler, we must re-enter the

		 * interpreter

		 */

		status2 = acpi_ex_enter_interpreter();

		if (ACPI_FAILURE(status2)) {

			return_ACPI_STATUS(status2);

		}

		acpi_ex_reacquire_interpreter();

	}



	return_ACPI_STATUS(status);

drivers/acpi/events/evxface.c

+2 −4
Original line number Diff line number Diff line
@@ -768,11 +768,9 @@ acpi_status acpi_acquire_global_lock(u16 timeout, u32 * handle) 
		return (AE_BAD_PARAMETER);

	}



	status = acpi_ex_enter_interpreter();

	if (ACPI_FAILURE(status)) {

		return (status);

	}

	/* Must lock interpreter to prevent race conditions */



	acpi_ex_enter_interpreter();

	status = acpi_ev_acquire_global_lock(timeout);

	acpi_ex_exit_interpreter();

drivers/acpi/executer/excreate.c

+1 −4
Original line number Diff line number Diff line
@@ -583,10 +583,7 @@ acpi_ex_create_method(u8 * aml_start, 
	 * Get the sync_level. If method is serialized, a mutex will be

	 * created for this method when it is parsed.

	 */

	if (acpi_gbl_all_methods_serialized) {

		obj_desc->method.sync_level = 0;

		obj_desc->method.method_flags |= AML_METHOD_SERIALIZED;

	} else if (method_flags & AML_METHOD_SERIALIZED) {

	if (method_flags & AML_METHOD_SERIALIZED) {

		/*

		 * ACPI 1.0: sync_level = 0

		 * ACPI 2.0: sync_level = sync_level in method declaration

drivers/acpi/executer/exsystem.c

+7 −23
Original line number Diff line number Diff line
@@ -66,7 +66,6 @@ ACPI_MODULE_NAME("exsystem") 
acpi_status acpi_ex_system_wait_semaphore(acpi_semaphore semaphore, u16 timeout)

{

	acpi_status status;

	acpi_status status2;



	ACPI_FUNCTION_TRACE(ex_system_wait_semaphore);
@@ -79,7 +78,7 @@ acpi_status acpi_ex_system_wait_semaphore(acpi_semaphore semaphore, u16 timeout) 


		/* We must wait, so unlock the interpreter */



		acpi_ex_exit_interpreter();

		acpi_ex_relinquish_interpreter();



		status = acpi_os_wait_semaphore(semaphore, 1, timeout);
@@ -89,13 +88,7 @@ acpi_status acpi_ex_system_wait_semaphore(acpi_semaphore semaphore, u16 timeout) 


		/* Reacquire the interpreter */



		status2 = acpi_ex_enter_interpreter();

		if (ACPI_FAILURE(status2)) {



			/* Report fatal error, could not acquire interpreter */



			return_ACPI_STATUS(status2);

		}

		acpi_ex_reacquire_interpreter();

	}



	return_ACPI_STATUS(status);
@@ -119,7 +112,6 @@ acpi_status acpi_ex_system_wait_semaphore(acpi_semaphore semaphore, u16 timeout) 
acpi_status acpi_ex_system_wait_mutex(acpi_mutex mutex, u16 timeout)

{

	acpi_status status;

	acpi_status status2;



	ACPI_FUNCTION_TRACE(ex_system_wait_mutex);
@@ -132,7 +124,7 @@ acpi_status acpi_ex_system_wait_mutex(acpi_mutex mutex, u16 timeout) 


		/* We must wait, so unlock the interpreter */



		acpi_ex_exit_interpreter();

		acpi_ex_relinquish_interpreter();



		status = acpi_os_acquire_mutex(mutex, timeout);
@@ -142,13 +134,7 @@ acpi_status acpi_ex_system_wait_mutex(acpi_mutex mutex, u16 timeout) 


		/* Reacquire the interpreter */



		status2 = acpi_ex_enter_interpreter();

		if (ACPI_FAILURE(status2)) {



			/* Report fatal error, could not acquire interpreter */



			return_ACPI_STATUS(status2);

		}

		acpi_ex_reacquire_interpreter();

	}



	return_ACPI_STATUS(status);
@@ -209,20 +195,18 @@ acpi_status acpi_ex_system_do_stall(u32 how_long) 


acpi_status acpi_ex_system_do_suspend(acpi_integer how_long)

{

	acpi_status status;



	ACPI_FUNCTION_ENTRY();



	/* Since this thread will sleep, we must release the interpreter */



	acpi_ex_exit_interpreter();

	acpi_ex_relinquish_interpreter();



	acpi_os_sleep(how_long);



	/* And now we must get the interpreter again */



	status = acpi_ex_enter_interpreter();

	return (status);

	acpi_ex_reacquire_interpreter();

	return (AE_OK);

}



/*******************************************************************************