Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d06ccd0 authored by Harry Wentland's avatar Harry Wentland Committed by Alex Deucher
Browse files

drm/amd/display: Fix access of wrong array element TF format conversion 



Found by smatch:
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:357
convert_to_custom_float() error: buffer overflow 'arr_points' 2 <= 2
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:358
convert_to_custom_float() warn: buffer overflow 'arr_points' 2 <= 2

Regression:
drm/amd/display: Remove extra arr_points element

Signed-off-by: default avatarHarry Wentland <harry.wentland@amd.com>
Reviewed-by: default avatarTony Cheng <Tony.Cheng@amd.com>
Acked-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 77bb51eb

drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c

+2 −2
Original line number Diff line number Diff line
@@ -354,8 +354,8 @@ static bool convert_to_custom_float(struct pwl_result_data *rgb_resulted, 
		return false;

	}



	if (!convert_to_custom_float_format(arr_points[2].slope, &fmt,

					    &arr_points[2].custom_float_slope)) {

	if (!convert_to_custom_float_format(arr_points[1].slope, &fmt,

					    &arr_points[1].custom_float_slope)) {

		BREAK_TO_DEBUGGER();

		return false;

	}