Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ceba98d authored by Takashi Iwai's avatar Takashi Iwai Committed by Mark Brown
Browse files

regmap: Skip read-only registers in regcache_sync() 



regcache_sync() spews warnings when a value was cached for a read-only
register as it tries to write all registers no matter whether they are
writable or not.  This patch adds regmap_wrtieable() checks for
avoiding it in regcache_sync_block_single() and regcache_block_raw().

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c517d838

drivers/base/regmap/regcache.c

+4 −2
Original line number Diff line number Diff line
@@ -608,7 +608,8 @@ static int regcache_sync_block_single(struct regmap *map, void *block, 
	for (i = start; i < end; i++) {

		regtmp = block_base + (i * map->reg_stride);



		if (!regcache_reg_present(cache_present, i))

		if (!regcache_reg_present(cache_present, i) ||

		    !regmap_writeable(map, regtmp))

			continue;



		val = regcache_get_val(map, block, i);
@@ -677,7 +678,8 @@ static int regcache_sync_block_raw(struct regmap *map, void *block, 
	for (i = start; i < end; i++) {

		regtmp = block_base + (i * map->reg_stride);



		if (!regcache_reg_present(cache_present, i)) {

		if (!regcache_reg_present(cache_present, i) ||

		    !regmap_writeable(map, regtmp)) {

			ret = regcache_sync_block_raw_flush(map, &data,

							    base, regtmp);

			if (ret != 0)