Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4cdd641d authored by Julia Lawall's avatar Julia Lawall Committed by Michael Ellerman
Browse files

powerpc/fsl: fsl_soc: delete unneeded test before of_node_put 

Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Acked-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 0f9da5cb

arch/powerpc/sysdev/fsl_soc.c

+1 −2
Original line number Diff line number Diff line
@@ -197,7 +197,6 @@ static int __init setup_rstcr(void) 
	if (!rstcr && ppc_md.restart == fsl_rstcr_restart)

		printk(KERN_ERR "No RSTCR register, warm reboot won't work\n");



	if (np)

	of_node_put(np);



	return 0;