Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4bd95324 authored by Filipe Manana's avatar Filipe Manana Committed by Greg Kroah-Hartman
Browse files

Btrfs: add missing inode version, ctime and mtime updates when punching hole 



commit 179006688a7e888cbff39577189f2e034786d06a upstream.

If the range for which we are punching a hole covers only part of a page,
we end up updating the inode item but we skip the update of the inode's
iversion, mtime and ctime. Fix that by ensuring we update those properties
of the inode.

A patch for fstests test case generic/059 that tests this as been sent
along with this fix.

Fixes: 2aaa6655 ("Btrfs: add hole punching")
Fixes: e8c1c76e ("Btrfs: add missing inode update when punching hole")
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fffedf5c

fs/btrfs/file.c

+5 −0
Original line number Diff line number Diff line
@@ -2732,6 +2732,11 @@ static int btrfs_punch_hole(struct inode *inode, loff_t offset, loff_t len) 
		 * for detecting, at fsync time, if the inode isn't yet in the

		 * log tree or it's there but not up to date.

		 */

		struct timespec64 now = current_time(inode);



		inode_inc_iversion(inode);

		inode->i_mtime = now;

		inode->i_ctime = now;

		trans = btrfs_start_transaction(root, 1);

		if (IS_ERR(trans)) {

			err = PTR_ERR(trans);