Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b3f2b60 authored by Paul Gortmaker's avatar Paul Gortmaker Committed by Lee Jones
Browse files

mfd: ab8500-debugfs: Make it explicitly non-modular 



The Kconfig currently controlling compilation of this code is:

drivers/mfd/Kconfig:config AB8500_DEBUG
drivers/mfd/Kconfig:       bool "Enable debug info via debugfs"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.

Since module_init was not in use by this code, the init ordering
remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 31cbae22

drivers/mfd/ab8500-debugfs.c

+2 −19
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ 
#include <linux/seq_file.h>

#include <linux/uaccess.h>

#include <linux/fs.h>

#include <linux/module.h>

#include <linux/init.h>

#include <linux/debugfs.h>

#include <linux/platform_device.h>

#include <linux/interrupt.h>
@@ -3234,33 +3234,16 @@ static int ab8500_debug_probe(struct platform_device *plf) 
	return -ENOMEM;

}



static int ab8500_debug_remove(struct platform_device *plf)

{

	debugfs_remove_recursive(ab8500_dir);



	return 0;

}



static struct platform_driver ab8500_debug_driver = {

	.driver = {

		.name = "ab8500-debug",

		.suppress_bind_attrs = true,

	},

	.probe  = ab8500_debug_probe,

	.remove = ab8500_debug_remove

};



static int __init ab8500_debug_init(void)

{

	return platform_driver_register(&ab8500_debug_driver);

}



static void __exit ab8500_debug_exit(void)

{

	platform_driver_unregister(&ab8500_debug_driver);

}

subsys_initcall(ab8500_debug_init);
 
module_exit(ab8500_debug_exit);



MODULE_AUTHOR("Mattias WALLIN <mattias.wallin@stericsson.com");

MODULE_DESCRIPTION("AB8500 DEBUG");

MODULE_LICENSE("GPL v2");