Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b30a069 authored by Andrew F. Davis's avatar Andrew F. Davis Committed by Greg Kroah-Hartman
Browse files

firmware: ti_sci: Always request response from firmware 



commit 66f030eac257a572fbedab3d9646d87d647351fd upstream.

TI-SCI firmware will only respond to messages when the
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED flag is set. Most messages already do
this, set this for the ones that do not.

This will be enforced in future firmware that better match the TI-SCI
specifications, this patch will not break users of existing firmware.

Fixes: aa276781 ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
Signed-off-by: default avatarAndrew F. Davis <afd@ti.com>
Acked-by: default avatarNishanth Menon <nm@ti.com>
Tested-by: default avatarAlejandro Hernandez <ajhernandez@ti.com>
Signed-off-by: default avatarTero Kristo <t-kristo@ti.com>
Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3dfc787f

drivers/firmware/ti_sci.c

+4 −4
Original line number Diff line number Diff line
@@ -463,9 +463,9 @@ static int ti_sci_cmd_get_revision(struct ti_sci_info *info) 
	struct ti_sci_xfer *xfer;

	int ret;



	/* No need to setup flags since it is expected to respond */

	xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_VERSION,

				   0x0, sizeof(struct ti_sci_msg_hdr),

				   TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,

				   sizeof(struct ti_sci_msg_hdr),

				   sizeof(*rev_info));

	if (IS_ERR(xfer)) {

		ret = PTR_ERR(xfer);
@@ -593,9 +593,9 @@ static int ti_sci_get_device_state(const struct ti_sci_handle *handle, 
	info = handle_to_ti_sci_info(handle);

	dev = info->dev;



	/* Response is expected, so need of any flags */

	xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_GET_DEVICE_STATE,

				   0, sizeof(*req), sizeof(*resp));

				   TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,

				   sizeof(*req), sizeof(*resp));

	if (IS_ERR(xfer)) {

		ret = PTR_ERR(xfer);

		dev_err(dev, "Message alloc failed(%d)\n", ret);