Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a562283 authored by Christian König's avatar Christian König Committed by Alex Deucher
Browse files

drm/amdgpu: cleanup scheduler fence get/put dance 



The code was correct, but getting two references when the ownership
is linearly moved on is a bit awkward and just overhead.

Signed: Christian König <christian.koenig@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 7034decf

drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -64,7 +64,6 @@ static struct fence *amdgpu_sched_run_job(struct amd_sched_job *sched_job) 
		job->free_job(job);

		job->free_job(job);





	mutex_unlock(&job->job_lock);

	mutex_unlock(&job->job_lock);

	fence_put(&job->base.s_fence->base);

	kfree(job);

	kfree(job);

	return fence ? &fence->base : NULL;

	return fence ? &fence->base : NULL;

}

}

drivers/gpu/drm/amd/scheduler/gpu_scheduler.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -285,7 +285,6 @@ int amd_sched_entity_push_job(struct amd_sched_job *sched_job) 
	if (!fence)

	if (!fence)

		return -ENOMEM;

		return -ENOMEM;





	fence_get(&fence->base);

	sched_job->s_fence = fence;

	sched_job->s_fence = fence;





	wait_event(entity->sched->job_scheduled,

	wait_event(entity->sched->job_scheduled,