Commit 4a262b14 authored Oct 12, 2016 by Shawn Lin Committed by Heiko Stuebner Oct 16, 2016

clk: rockchip: don't return NULL when failing to register ddrclk branch



rockchip_clk_register_ddrclk should not return NULL when failing
to call clk_register, otherwise rockchip_clk_register_branches
prints "unknown clock type". The actual case is that it's a known
clock type but we fail to register it, which may makes user confuse
the reason of failure. And the pr_err here is pointless as
rockchip_clk_register_branches will also print the similar message.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>

parent 1001354c

drivers/clk/rockchip/clk-ddr.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -144,11 +144,8 @@ struct clk rockchip_clk_register_ddrclk(const char name, int flags,
		ddrclk->ddr_flag = ddr_flag;

		clk = clk_register(NULL, &ddrclk->hw);
		if (IS_ERR(clk)) {
		pr_err("%s: could not register ddrclk %s\n", __func__, name);
		if (IS_ERR(clk))
		kfree(ddrclk);
		return NULL;
		}

		return clk;
		}