Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a102b4d authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Torvalds
Browse files

drivers/mailbox/omap: make mbox->irq signed for error handling 



There is a bug in omap2_mbox_probe() where we try do:

		mbox->irq = platform_get_irq(pdev, info->irq_id);
		if (mbox->irq < 0) {

The problem is that mbox->irq is unsigned so the error handling doesn't
work.  I've changed it to a signed integer.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: Suman Anna <s-anna@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Omar Ramirez Luna <omar.ramirez@copitl.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0c79a8e2

drivers/mailbox/omap-mbox.h

+1 −1
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ struct omap_mbox_queue { 


struct omap_mbox {

	const char		*name;

	unsigned int		irq;

	int			irq;

	struct omap_mbox_queue	*txq, *rxq;

	struct omap_mbox_ops	*ops;

	struct device		*dev;