Commit 49d66a70 authored Jun 16, 2007 by Gerrit Renker Committed by David S. Miller Jul 10, 2007

[CCID3]: Fix a bug in the send time processing

ccid3_hc_tx_send_packet currently returns 0 when the time difference between
current time and t_nom is less than 1000 microseconds.

In this case the packet is sent immediately; but, unlike other packets that can
be emitted on first attempt, it will not have its window counter updated and
its options set as required. This is a bug.

Fix: Require the time difference to be at least 1000 microseconds. The
algorithm then converges: time differences > 1000 microseconds trigger the
timer in dccp_write_xmit; after timer expiry this function is tried again; when
the time difference is less than 1000, the packet will have its options added
and window counter updated as required.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>

parent 8132da4d

net/dccp/ccids/ccid3.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -363,7 +363,7 @@ static int ccid3_hc_tx_send_packet(struct sock sk, struct sk_buff skb)
		* else
		* // send the packet in (t_nom - t_now) milliseconds.
		*/
		if (delay - (s64)hctx->ccid3hctx_delta >= 0)
		if (delay - (s64)hctx->ccid3hctx_delta >= 1000)
		return (u32)delay / 1000L;

		ccid3_hc_tx_update_win_count(hctx, now);