Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 49c37c03 authored by Dan Rosenberg's avatar Dan Rosenberg Committed by David S. Miller
Browse files

drivers/net/cxgb3/cxgb3_main.c: prevent reading uninitialized stack memory 



Fixed formatting (tabs and line breaks).

The CHELSIO_GET_QSET_NUM device ioctl allows unprivileged users to read
4 bytes of uninitialized stack memory, because the "addr" member of the
ch_reg struct declared on the stack in cxgb_extension_ioctl() is not
altered or zeroed before being copied back to the user.  This patch
takes care of it.

Signed-off-by: default avatarDan Rosenberg <dan.j.rosenberg@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 44467187

drivers/net/cxgb3/cxgb3_main.c

+2 −0
Original line number Diff line number Diff line
@@ -2296,6 +2296,8 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr) 
	case CHELSIO_GET_QSET_NUM:{

		struct ch_reg edata;



		memset(&edata, 0, sizeof(struct ch_reg));



		edata.cmd = CHELSIO_GET_QSET_NUM;

		edata.val = pi->nqsets;

		if (copy_to_user(useraddr, &edata, sizeof(edata)))