Commit 498fe23a authored Sep 13, 2018 by Takashi Sakamoto Committed by Takashi Iwai Sep 13, 2018

ALSA: oxfw: fix memory leak of private data



Although private data of sound card instance is usually allocated in the
tail of the instance, drivers in ALSA firewire stack allocate the private
data before allocating the instance. In this case, the private data
should be released explicitly at .private_free callback of the instance.

This commit fixes memory leak following to the above design.

Fixes: 6c29230e ('ALSA: oxfw: delayed registration of sound card')
Cc: <stable@vger.kernel.org> # v4.7+
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 8d28277c

sound/firewire/oxfw/oxfw.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -130,6 +130,7 @@ static void oxfw_free(struct snd_oxfw *oxfw)

		kfree(oxfw->spec);
		mutex_destroy(&oxfw->mutex);
		kfree(oxfw);
		}

		/*