Commit 496b318e authored May 13, 2011 by Laszlo Ersek Committed by Konrad Rzeszutek Wilk May 13, 2011

xen/blkback: fix xenbus_transaction_start() hang caused by double xenbus_transaction_end()

vbd_resize() up_read()'s xs_state.suspend_mutex twice in a row via double
xenbus_transaction_end() calls. The next down_read() in
xenbus_transaction_start() (at eg. the next resize attempt) hangs.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=618317



Acked-by: Jan Beulich <jbeulich@novell.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

parent 51854322

drivers/block/xen-blkback/blkback.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -226,6 +226,7 @@ static void xen_vbd_resize(struct xen_blkif *blkif)
		goto again;
		if (err)
		pr_warn(DRV_PFX "Error ending transaction");
		return;
		abort:
		xenbus_transaction_end(xbt, 1);
		}