Commit 495e34e6 authored Mar 12, 2019 by Kangjie Lu Committed by Greg Kroah-Hartman May 31, 2019

thunderbolt: property: Fix a NULL pointer dereference



[ Upstream commit 106204b56f60abf1bead7dceb88f2be3e34433da ]

In case kzalloc fails, the fix releases resources and returns
-ENOMEM to avoid the NULL pointer dereference.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 70611b1b

drivers/thunderbolt/property.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -551,6 +551,11 @@ int tb_property_add_data(struct tb_property_dir parent, const char key,

		property->length = size / 4;
		property->value.data = kzalloc(size, GFP_KERNEL);
		if (!property->value.data) {
		kfree(property);
		return -ENOMEM;
		}

		memcpy(property->value.data, buf, buflen);

		list_add_tail(&property->list, &parent->properties);