Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 49528b4e authored by Bob Peterson's avatar Bob Peterson Committed by Steven Whitehouse
Browse files

GFS2: Fix a use-after-free that coverity spotted 



In function gfs2_inplace_release it was trying to unlock a gfs2_holder
structure associated with a reservation, after said reservation was
freed. The problem is that the statements have the wrong order.
This patch corrects the order so that the reservation is freed after
the gfs2_holder is unlocked.

Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
parent e0c2a9aa

fs/gfs2/rgrp.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1108,9 +1108,9 @@ void gfs2_inplace_release(struct gfs2_inode *ip) 
{

{

	struct gfs2_blkreserv *rs = ip->i_res;

	struct gfs2_blkreserv *rs = ip->i_res;





	gfs2_blkrsv_put(ip);

	if (rs->rs_rgd_gh.gh_gl)

	if (rs->rs_rgd_gh.gh_gl)

		gfs2_glock_dq_uninit(&rs->rs_rgd_gh);

		gfs2_glock_dq_uninit(&rs->rs_rgd_gh);

	gfs2_blkrsv_put(ip);

}

}





/**

/**