Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48e876a2 authored by Andres Rodriguez's avatar Andres Rodriguez Committed by Oded Gabbay
Browse files

drm/amdkfd: use a high priority workqueue for IH work 



In systems under heavy load the IH work may experience significant
scheduling delays.

Under load + system workqueue:
    Max Latency: 7.023695 ms
    Avg Latency: 0.263994 ms

Under load + high priority workqueue:
    Max Latency: 1.162568 ms
    Avg Latency: 0.163213 ms

Further work is required to measure the impact of per-cpu settings on IH
performance.

Signed-off-by: default avatarAndres Rodriguez <andres.rodriguez@amd.com>
Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Acked-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
parent 0f875e3f

drivers/gpu/drm/amd/amdkfd/kfd_device.c

+1 −1
Original line number Diff line number Diff line
@@ -403,7 +403,7 @@ void kgd2kfd_interrupt(struct kfd_dev *kfd, const void *ih_ring_entry) 
	if (kfd->interrupts_active

	    && interrupt_is_wanted(kfd, ih_ring_entry)

	    && enqueue_ih_ring_entry(kfd, ih_ring_entry))

		schedule_work(&kfd->interrupt_work);

		queue_work(kfd->ih_wq, &kfd->interrupt_work);



	spin_unlock(&kfd->interrupt_lock);

}

drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c

+2 −1
Original line number Diff line number Diff line
@@ -61,6 +61,7 @@ int kfd_interrupt_init(struct kfd_dev *kfd) 
		return r;

	}



	kfd->ih_wq = alloc_workqueue("KFD IH", WQ_HIGHPRI, 1);

	spin_lock_init(&kfd->interrupt_lock);



	INIT_WORK(&kfd->interrupt_work, interrupt_wq);
@@ -95,7 +96,7 @@ void kfd_interrupt_exit(struct kfd_dev *kfd) 
	 * work-queue items that will access interrupt_ring. New work items

	 * can't be created because we stopped interrupt handling above.

	 */

	flush_work(&kfd->interrupt_work);

	flush_workqueue(kfd->ih_wq);



	kfifo_free(&kfd->ih_fifo);

}

drivers/gpu/drm/amd/amdkfd/kfd_priv.h

+1 −0
Original line number Diff line number Diff line
@@ -184,6 +184,7 @@ struct kfd_dev { 


	/* Interrupts */

	struct kfifo ih_fifo;

	struct workqueue_struct *ih_wq;

	struct work_struct interrupt_work;

	spinlock_t interrupt_lock;